SuccessChanges

Summary

  1. mlv_play: fix conflict with NotifyBox (visible when Canon code shows "No image", with e.g. FPS override)
  2. Display filters: minor tweak for the use-after-free fix
  3. Fix conflict between module display filters and core filters; added some comments
  4. raw_hist_get_percentile_level(s): fix error handling
  5. Display filters: fix use-after-free (for example, fixes crash when also using mlv_play) Steps to reproduce (before the fix): - enable some display filter (defishing, raw preview, anything) - use a low FPS to increase the chances of triggering the race condition - trigger mlv_play (press PLAY) to playback some video - repeat 1..5 times until the camera crashes For more insight, run the current "don't click me" test in playback mode, instead of triggering mlv_play, and print YUV422_LV_BUFFER_DISPLAY_ADDR.
  6. Memory backend: minor tweaks
  7. Memory backend: fix indentation in search_for_allocator
  8. Memory backend: refactored search_for_allocator to remove cascaded if's (note: indentation broken to make reviewing easier)
  9. Memory backend: limit shoot_malloc calls to 1000 (fixes the test from previous commit)
  10. New memory test that fails on 5D3 (don't click me)
  11. mlv_play: don't create playlist twice
  12. mlv_play: don't use a background task for playlist (just in case; troubleshooting a crash)
  13. mlv_play: some sanity checks
Changeset 10338:3046b3f52457 by Alex:
mlv_play: fix conflict with NotifyBox (visible when Canon code shows "No image", with e.g. FPS override)
The file was modifiedmodules/mlv_play/mlv_play.c (diff)
Changeset 10337:ea321def5491 by Alex:
Display filters: minor tweak for the use-after-free fix
The file was modifiedsrc/tweaks.c (diff)
Changeset 10336:8671cfbe3a14 by Alex:
Fix conflict between module display filters and core filters; added some comments
The file was modifiedsrc/module.c (diff)
Changeset 10335:e03286864ac9 by Alex:
raw_hist_get_percentile_level(s): fix error handling
The file was modifiedsrc/histogram.c (diff)
Changeset 10334:880fdec242b5 by Alex:
Display filters: fix use-after-free (for example, fixes crash when also using mlv_play)<br><br>Steps to reproduce (before the fix):<br>- enable some display filter (defishing, raw preview, anything)<br>- use a low FPS to increase the chances of triggering the race condition<br>- trigger mlv_play (press PLAY) to playback some video<br>- repeat 1..5 times until the camera crashes<br><br>For more insight, run the current &quot;don&#039;t click me&quot; test in playback mode, instead of triggering mlv_play, and print YUV422_LV_BUFFER_DISPLAY_ADDR.
The file was modifiedsrc/tweaks.c (diff)
Changeset 10333:db270459ffce by Alex:
Memory backend: minor tweaks
The file was modifiedsrc/mem.c (diff)
Changeset 10332:fa65504337c9 by Alex:
Memory backend: fix indentation in search_for_allocator
The file was modifiedsrc/mem.c (diff)
Changeset 10331:74b8a83b03bc by Alex:
Memory backend: refactored search_for_allocator to remove cascaded if&#039;s<br>(note: indentation broken to make reviewing easier)
The file was modifiedsrc/mem.c (diff)
Changeset 10330:7ced1bf82ecb by Alex:
Memory backend: limit shoot_malloc calls to 1000 (fixes the test from previous commit)
The file was modifiedsrc/mem.c (diff)
Changeset 10329:5f7dea3505f1 by Alex:
New memory test that fails on 5D3 (don&#039;t click me)
The file was modifiedsrc/debug.c (diff)
Changeset 10328:16d201153dee by Alex:
mlv_play: don&#039;t create playlist twice
The file was modifiedmodules/mlv_play/mlv_play.c (diff)
Changeset 10327:c4312f6d6376 by Alex:
mlv_play: don&#039;t use a background task for playlist (just in case; troubleshooting a crash)
The file was modifiedmodules/mlv_play/mlv_play.c (diff)
Changeset 10326:712ecfd08e63 by Alex:
mlv_play: some sanity checks
The file was modifiedmodules/mlv_play/mlv_play.c (diff)